Migrate preferences from writable stores to runes#42
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR migrates preferences from Svelte writable stores to runes, modernizing the state management approach. The migration changes how preferences are created, accessed, and managed throughout the codebase.
- Replaced
PreferencesManager.createStore()withcreatePreference()that returns getter functions - Updated all preference access from
$storesyntax to function calls likepreference() - Migrated subscription-based reactivity to
$effect()for handling preference changes
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/treetop/Treetop.svelte | Updated preference access syntax and replaced store subscription with $effect() |
| src/treetop/PreferencesManager.ts | Replaced writable stores with SvelteMap and getter functions |
| src/treetop/PreferencesManager.test.ts | Updated tests to use new preference API and function calls |
| src/treetop/Folder.svelte.test.ts | Changed test setup to use preference getter functions |
| src/treetop/Bookmark.svelte.test.ts | Modified test mocks to use preference getter pattern |
| src/treetop/Bookmark.svelte | Updated preference access from store syntax to function calls |
| _locales/en/messages.json | Added new error message for history manager refresh |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.